-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show spinner animation when adding plugins #8234
feat: Show spinner animation when adding plugins #8234
Conversation
✅ Deploy Preview for meltano canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8234 +/- ##
==========================================
- Coverage 91.50% 91.49% -0.02%
==========================================
Files 244 244
Lines 19125 19127 +2
Branches 2140 2141 +1
==========================================
- Hits 17501 17500 -1
- Misses 1343 1346 +3
Partials 281 281 ☔ View full report in Codecov by Sentry. |
@raiatul14 Would you still be interested in getting this across? |
@edgarrmondragon sure. If you feel something is missing then please let me know. Thanks! |
I think the current implementation is missing what's probably the most important long-running command, i.e. |
Closes #7803
added yaspin spinner animation for 'add plugin' service